Commit 811fbb1f authored Jan 30, 2015 by Peter Meerwald Committed by Tomi Valkeinen Feb 04, 2015

omapfb: Return error code when applying overlay settings fails



the check of the return code is missing, user space does not get notified
about the error condition:

omapdss OVERLAY error: overlay 2 horizontally not inside the display area (403 + 800 >= 800)
omapdss APPLY error: failed to apply settings: illegal configuration.

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent a2408154

drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -137,8 +137,11 @@ static int omapfb_setup_plane(struct fb_info fbi, struct omapfb_plane_info pi)
		goto undo;
		}

		if (ovl->manager)
		ovl->manager->apply(ovl->manager);
		if (ovl->manager) {
		r = ovl->manager->apply(ovl->manager);
		if (r)
		goto undo;
		}

		if (pi->enabled) {
		r = ovl->enable(ovl);