Commit 810be30d authored by Tzung-Bi Shih's avatar Tzung-Bi Shih
Browse files

platform/chrome: cros_ec_proto: separate cros_ec_xfer_command() 



cros_ec_send_command() has extra logic to handle EC_RES_IN_PROGRESS.
Separate the command transfer part into cros_ec_xfer_command() so
that other functions can re-use it.

Reviewed-by: default avatarGuenter Roeck <groeck@chromium.org>
Signed-off-by: default avatarTzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220718050914.2267370-6-tzungbi@kernel.org
parent da95f691

drivers/platform/chrome/cros_ec_proto.c

+10 −3
Original line number Diff line number Diff line
@@ -107,7 +107,7 @@ static int prepare_tx_legacy(struct cros_ec_device *ec_dev, 
	return EC_MSG_TX_PROTO_BYTES + msg->outsize;

}



static int cros_ec_send_command(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)

static int cros_ec_xfer_command(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)

{

	int ret;

	int (*xfer_fxn)(struct cros_ec_device *ec, struct cros_ec_command *msg);
@@ -123,14 +123,21 @@ static int cros_ec_send_command(struct cros_ec_device *ec_dev, struct cros_ec_co 
		 * the EC is trying to use protocol v2, on an underlying

		 * communication mechanism that does not support v2.

		 */

		dev_err_once(ec_dev->dev,

			     "missing EC transfer API, cannot send command\n");

		dev_err_once(ec_dev->dev, "missing EC transfer API, cannot send command\n");

		return -EIO;

	}



	trace_cros_ec_request_start(msg);

	ret = (*xfer_fxn)(ec_dev, msg);

	trace_cros_ec_request_done(msg, ret);



	return ret;

}



static int cros_ec_send_command(struct cros_ec_device *ec_dev, struct cros_ec_command *msg)

{

	int ret = cros_ec_xfer_command(ec_dev, msg);



	if (msg->result == EC_RES_IN_PROGRESS) {

		int i;

		struct cros_ec_command *status_msg;