Commit 81022a17 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Dmitry Torokhov
Browse files

Input: omap4-keypad - fix pm_runtime_get_sync() error checking 



If the device is already in a runtime PM enabled state
pm_runtime_get_sync() will return 1, so a test for negative
value should be used to check for errors.

Fixes: f77621cc ("Input: omap-keypad - dynamically handle register offsets")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220412070131.19848-1-linmq006@gmail.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent fd0a4b39

drivers/input/keyboard/omap4-keypad.c

+1 −1
Original line number Diff line number Diff line
@@ -393,7 +393,7 @@ static int omap4_keypad_probe(struct platform_device *pdev) 
	 * revision register.

	 */

	error = pm_runtime_get_sync(dev);

	if (error) {

	if (error < 0) {

		dev_err(dev, "pm_runtime_get_sync() failed\n");

		pm_runtime_put_noidle(dev);

		return error;