Commit 80ef9286 authored by Ammar Faizi's avatar Ammar Faizi Committed by Jakub Kicinski
Browse files

net: devlink: Fix missing mutex_unlock() call 



Commit 2dec18ad forgets to call mutex_unlock() before the function
returns in the error path:

   New smatch warnings:
   net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \
   returns '&region->snapshot_lock'.

Make sure we call mutex_unlock() in this error path.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 2dec18ad ("net: devlink: remove region snapshots list dependency on devlink->lock")
Signed-off-by: default avatarAmmar Faizi <ammarfaizi2@gnuweeb.org>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20220801115742.1309329-1-ammar.faizi@intel.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d81c7cdd

net/core/devlink.c

+4 −2
Original line number Diff line number Diff line
@@ -6315,8 +6315,10 @@ devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info) 


		snapshot = devlink_region_snapshot_get_by_id(region,

							     snapshot_id);

		if (WARN_ON(!snapshot))

			return -EINVAL;

		if (WARN_ON(!snapshot)) {

			err = -EINVAL;

			goto unlock;

		}



		msg = devlink_nl_region_notify_build(region, snapshot,

						     DEVLINK_CMD_REGION_NEW,