Unverified Commit 80d53171 authored Sep 20, 2022 by Pierre-Louis Bossart Committed by Mark Brown Sep 20, 2022

ASoC: SOF: ipc4-topology: clarify calculation precedence



cppcheck warning:

sound/soc/sof/ipc4-topology.c:334:64: style: Clarify calculation
precedence for '&' and '?'. [clarifyCalculation]
 type = fw_module->man4_module_entry.type & SOF_IPC4_MODULE_DP ? 1 : 0;
                                                               ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Chao Song <chao.song@intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20220920145405.2089147-2-pierre-louis.bossart@linux.intel.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 9f27530a

sound/soc/sof/ipc4-topology.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -331,7 +331,7 @@ static int sof_ipc4_widget_setup_msg(struct snd_sof_widget *swidget, struct sof_
		msg->extension = SOF_IPC4_MOD_EXT_PPL_ID(swidget->pipeline_id);
		msg->extension \|= SOF_IPC4_MOD_EXT_CORE_ID(swidget->core);

		type = fw_module->man4_module_entry.type & SOF_IPC4_MODULE_DP ? 1 : 0;
		type = (fw_module->man4_module_entry.type & SOF_IPC4_MODULE_DP) ? 1 : 0;
		msg->extension \|= SOF_IPC4_MOD_EXT_DOMAIN(type);

		return 0;