Commit 80b9c1be authored by Yang Yingliang's avatar Yang Yingliang Committed by Takashi Iwai
Browse files

ALSA: ppc: fix error return code in snd_pmac_probe() 



If snd_pmac_tumbler_init() or snd_pmac_tumbler_post_init() fails,
snd_pmac_probe() need return error code.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210616021121.1991502-1-yangyingliang@huawei.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e381a14c

sound/ppc/powermac.c

+5 −1
Original line number Diff line number Diff line
@@ -79,7 +79,11 @@ static int snd_pmac_probe(struct platform_device *devptr) 
		sprintf(card->shortname, "PowerMac %s", name_ext);

		sprintf(card->longname, "%s (Dev %d) Sub-frame %d",

			card->shortname, chip->device_id, chip->subframe);

		if ( snd_pmac_tumbler_init(chip) < 0 || snd_pmac_tumbler_post_init() < 0)

		err = snd_pmac_tumbler_init(chip);

		if (err < 0)

			goto __error;

		err = snd_pmac_tumbler_post_init();

		if (err < 0)

			goto __error;

		break;

	case PMAC_AWACS: