Commit 80b892fc authored by Bo YU's avatar Bo YU Committed by Kalle Valo
Browse files

ath11k: Add checked value for ath11k_ahb_remove 



Return value form wait_for_completion_timeout should to be checked.

This is detected by Coverity: #CID:1464479 (CHECKED_RETURN)

Fixes: d5c65159 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: default avatarBo YU <tsu.yubo@gmail.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200621095136.7xdbzkthoxuw2qow@debian.debian-2
parent 21409151

drivers/net/wireless/ath/ath11k/ahb.c

+7 −3
Original line number Diff line number Diff line
@@ -718,12 +718,16 @@ static int ath11k_ahb_probe(struct platform_device *pdev) 
static int ath11k_ahb_remove(struct platform_device *pdev)

{

	struct ath11k_base *ab = platform_get_drvdata(pdev);

	unsigned long left;



	reinit_completion(&ab->driver_recovery);



	if (test_bit(ATH11K_FLAG_RECOVERY, &ab->dev_flags))

		wait_for_completion_timeout(&ab->driver_recovery,

	if (test_bit(ATH11K_FLAG_RECOVERY, &ab->dev_flags)) {

		left = wait_for_completion_timeout(&ab->driver_recovery,

						   ATH11K_AHB_RECOVERY_TIMEOUT);

		if (!left)

			ath11k_warn(ab, "failed to receive recovery response completion\n");

	}



	set_bit(ATH11K_FLAG_UNREGISTERING, &ab->dev_flags);

	cancel_work_sync(&ab->restart_work);