Commit 80b2bd73 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Saeed Mahameed
Browse files

net/mlx5: Don't use already freed action pointer 



The call to mlx5dr_action_destroy() releases "action" memory. That
pointer is set to miss_action later and generates the following smatch
error:

 drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c:53 set_miss_action()
 warn: 'action' was already freed.

Make sure that the pointer is always valid by setting NULL after destroy.

Fixes: 6a48faee ("net/mlx5: Add direct rule fs_cmd implementation")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 09e545f7

drivers/net/ethernet/mellanox/mlx5/core/steering/fs_dr.c

+4 −5
Original line number Diff line number Diff line
@@ -44,11 +44,10 @@ static int set_miss_action(struct mlx5_flow_root_namespace *ns, 
	err = mlx5dr_table_set_miss_action(ft->fs_dr_table.dr_table, action);

	if (err && action) {

		err = mlx5dr_action_destroy(action);

		if (err) {

		if (err)

			mlx5_core_err(ns->dev,

				      "Failed to destroy action (%d)\n", err);

		action = NULL;

			mlx5_core_err(ns->dev, "Failed to destroy action (%d)\n",

				      err);

		}

	}

	ft->fs_dr_table.miss_action = action;

	if (old_miss_action) {