Commit 80927822 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: scsi_dh_alua: Fix signedness bug in alua_rtpg() 

The "retval" variable needs to be signed for the error handling to work.

Link: https://lore.kernel.org/r/YLjMEAFNxOas1mIp@mwanda


Fixes: 7e26e3ea ("scsi: scsi_dh_alua: Check for negative result value")
Reviewed-by: default avatarMartin Wilck <mwilck@suse.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 8b1afb7a

drivers/scsi/device_handler/scsi_dh_alua.c

+2 −1
Original line number Diff line number Diff line
@@ -518,7 +518,8 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg) 
	int len, k, off, bufflen = ALUA_RTPG_SIZE;

	int group_id_old, state_old, pref_old, valid_states_old;

	unsigned char *desc, *buff;

	unsigned err, retval;

	unsigned err;

	int retval;

	unsigned int tpg_desc_tbl_off;

	unsigned char orig_transition_tmo;

	unsigned long flags;