Commit 80842a92 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

driver core: class: make class_create/remove_file*() options const 

The class_create_file*() and class_remove_file*() functions do not
modify the struct class at all, so mark them as const * to enforce that.

Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Link: https://lore.kernel.org/r/20230313181843.1207845-8-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cf41015e

drivers/base/class.c

+2 −2
Original line number Diff line number Diff line
@@ -87,7 +87,7 @@ static const struct kobj_type class_ktype = { 
static struct kset *class_kset;





int class_create_file_ns(struct class *cls, const struct class_attribute *attr,

int class_create_file_ns(const struct class *cls, const struct class_attribute *attr,

			 const void *ns)

{

	int error;
@@ -101,7 +101,7 @@ int class_create_file_ns(struct class *cls, const struct class_attribute *attr, 
}

EXPORT_SYMBOL_GPL(class_create_file_ns);



void class_remove_file_ns(struct class *cls, const struct class_attribute *attr,

void class_remove_file_ns(const struct class *cls, const struct class_attribute *attr,

			  const void *ns)

{

	if (cls)

include/linux/device/class.h

+5 −5
Original line number Diff line number Diff line
@@ -200,20 +200,20 @@ struct class_attribute { 
#define CLASS_ATTR_WO(_name) \

	struct class_attribute class_attr_##_name = __ATTR_WO(_name)



extern int __must_check class_create_file_ns(struct class *class,

extern int __must_check class_create_file_ns(const struct class *class,

					     const struct class_attribute *attr,

					     const void *ns);

extern void class_remove_file_ns(struct class *class,

extern void class_remove_file_ns(const struct class *class,

				 const struct class_attribute *attr,

				 const void *ns);



static inline int __must_check class_create_file(struct class *class,

static inline int __must_check class_create_file(const struct class *class,

						 const struct class_attribute *attr)

{

	return class_create_file_ns(class, attr, NULL);

}



static inline void class_remove_file(struct class *class,

static inline void class_remove_file(const struct class *class,

				     const struct class_attribute *attr)

{

	return class_remove_file_ns(class, attr, NULL);