Commit 805a6ef8 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bartosz Golaszewski
Browse files

gpio: zynq: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: default avatarMichal Simek <michal.simek@xilinx.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 308a028d

drivers/gpio/gpio-zynq.c

+3 −5
Original line number Diff line number Diff line
@@ -929,11 +929,9 @@ static int zynq_gpio_probe(struct platform_device *pdev) 


	/* Retrieve GPIO clock */

	gpio->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(gpio->clk)) {

		if (PTR_ERR(gpio->clk) != -EPROBE_DEFER)

			dev_err(&pdev->dev, "input clock not found.\n");

		return PTR_ERR(gpio->clk);

	}

	if (IS_ERR(gpio->clk))

		return dev_err_probe(&pdev->dev, PTR_ERR(gpio->clk), "input clock not found.\n");



	ret = clk_prepare_enable(gpio->clk);

	if (ret) {

		dev_err(&pdev->dev, "Unable to enable clock.\n");