Commit 801b5014 authored by tangmeng's avatar tangmeng Committed by Luis Chamberlain
Browse files

kernel/acct: move acct sysctls to its own file 



kernel/sysctl.c is a kitchen sink where everyone leaves their dirty
dishes, this makes it very difficult to maintain.

To help with this maintenance let's start by moving sysctls to places
where they actually belong.  The proc sysctl maintainers do not want to
know what sysctl knobs you wish to add for your own piece of code, we
just care about the core logic.

All filesystem syctls now get reviewed by fs folks. This commit
follows the commit of fs, move the acct sysctl to its own file,
kernel/acct.c.

Signed-off-by: default avatartangmeng <tangmeng@uniontech.com>
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
parent 9df91869

include/linux/acct.h

+0 −1
Original line number Diff line number Diff line
@@ -21,7 +21,6 @@ 


#ifdef CONFIG_BSD_PROCESS_ACCT

struct pid_namespace;

extern int acct_parm[]; /* for sysctl */

extern void acct_collect(long exitcode, int group_dead);

extern void acct_process(void);

extern void acct_exit_ns(struct pid_namespace *);

kernel/acct.c

+21 −1
Original line number Diff line number Diff line
@@ -70,11 +70,31 @@ 
 * Turned into sysctl-controllable parameters. AV, 12/11/98

 */



int acct_parm[3] = {4, 2, 30};

static int acct_parm[3] = {4, 2, 30};

#define RESUME		(acct_parm[0])	/* >foo% free space - resume */

#define SUSPEND		(acct_parm[1])	/* <foo% free space - suspend */

#define ACCT_TIMEOUT	(acct_parm[2])	/* foo second timeout between checks */



#ifdef CONFIG_SYSCTL

static struct ctl_table kern_acct_table[] = {

	{

		.procname       = "acct",

		.data           = &acct_parm,

		.maxlen         = 3*sizeof(int),

		.mode           = 0644,

		.proc_handler   = proc_dointvec,

	},

	{ }

};



static __init int kernel_acct_sysctls_init(void)

{

	register_sysctl_init("kernel", kern_acct_table);

	return 0;

}

late_initcall(kernel_acct_sysctls_init);

#endif /* CONFIG_SYSCTL */



/*

 * External references and all of the globals.

 */

kernel/sysctl.c

+0 −12
Original line number Diff line number Diff line
@@ -82,9 +82,6 @@ 
#ifdef CONFIG_SPARC

#include <asm/setup.h>

#endif

#ifdef CONFIG_BSD_PROCESS_ACCT

#include <linux/acct.h>

#endif

#ifdef CONFIG_RT_MUTEXES

#include <linux/rtmutex.h>

#endif
@@ -1856,15 +1853,6 @@ static struct ctl_table kern_table[] = { 
		.proc_handler	= proc_dostring,

	},

#endif

#ifdef CONFIG_BSD_PROCESS_ACCT

	{

		.procname	= "acct",

		.data		= &acct_parm,

		.maxlen		= 3*sizeof(int),

		.mode		= 0644,

		.proc_handler	= proc_dointvec,

	},

#endif

#ifdef CONFIG_MAGIC_SYSRQ

	{

		.procname	= "sysrq",