Commit 800c1443 authored by Bruce Allan's avatar Bruce Allan Committed by Tony Nguyen
Browse files

ice: remove unnecessary duplicated AQ command flag setting 



Commit a012dca9 ("ice: add ethtool -m support for reading i2c eeprom
modules") unnecessarily added the ICE_AQ_FLAG_BUF flag to the descriptor
when sending the indirect Read/Write SFF EEPROM AQ command. The flag is
already added later in the code flow for all indirect AQ commands, i.e.
commands that provide an additional data buffer.

Signed-off-by: default avatarBruce Allan <bruce.w.allan@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 5c57145a

drivers/net/ethernet/intel/ice/ice_common.c

+1 −1
Original line number Diff line number Diff line
@@ -3186,7 +3186,7 @@ ice_aq_sff_eeprom(struct ice_hw *hw, u16 lport, u8 bus_addr, 


	ice_fill_dflt_direct_cmd_desc(&desc, ice_aqc_opc_sff_eeprom);

	cmd = &desc.params.read_write_sff_param;

	desc.flags = cpu_to_le16(ICE_AQ_FLAG_RD | ICE_AQ_FLAG_BUF);

	desc.flags = cpu_to_le16(ICE_AQ_FLAG_RD);

	cmd->lport_num = (u8)(lport & 0xff);

	cmd->lport_num_valid = (u8)((lport >> 8) & 0x01);

	cmd->i2c_bus_addr = cpu_to_le16(((bus_addr >> 1) &