Commit 7ffba3bd authored by Alex Elder's avatar Alex Elder Committed by David S. Miller
Browse files

net: ipa: get rid of ipa_cmd_info->direction 



The direction field of the ipa_cmd_info structure is set, but never
used.  It seems it might have been used for the DMA_SHARED_MEM
immediate command, but the DIRECTION flag is set based on the value
of the passed-in direction flag there.

Anyway, remove this unused field from the ipa_cmd_info structure.
This is done as a separate patch to make it very obvious that it's
not required.

Signed-off-by: default avatarAlex Elder <elder@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2091c79a

drivers/net/ipa/gsi_trans.c

+1 −4
Original line number Diff line number Diff line
@@ -413,7 +413,6 @@ void gsi_trans_cmd_add(struct gsi_trans *trans, void *buf, u32 size, 
		       dma_addr_t addr, enum dma_data_direction direction,

		       enum ipa_cmd_opcode opcode)

{

	struct ipa_cmd_info *info;

	u32 which = trans->used++;

	struct scatterlist *sg;
@@ -438,9 +437,7 @@ void gsi_trans_cmd_add(struct gsi_trans *trans, void *buf, u32 size, 
	sg_dma_address(sg) = addr;

	sg_dma_len(sg) = size;



	info = &trans->info[which];

	info->opcode = opcode;

	info->direction = direction;

	trans->info[which].opcode = opcode;

}



/* Add a page transfer to a transaction.  It will fill the only TRE. */

drivers/net/ipa/ipa_cmd.h

+0 −2
Original line number Diff line number Diff line
@@ -50,11 +50,9 @@ enum ipa_cmd_opcode { 
 * struct ipa_cmd_info - information needed for an IPA immediate command

 *

 * @opcode:	The command opcode.

 * @direction:	Direction of data transfer for DMA commands

 */

struct ipa_cmd_info {

	enum ipa_cmd_opcode opcode;

	enum dma_data_direction direction;

};



/**