Commit 7fdd375e authored Dec 09, 2020 by Guillaume Nault Committed by David S. Miller Dec 09, 2020

net: sched: Fix dump of MPLS_OPT_LSE_LABEL attribute in cls_flower



TCA_FLOWER_KEY_MPLS_OPT_LSE_LABEL is a u32 attribute (MPLS label is
20 bits long).

Fixes the following bug:

 $ tc filter add dev ethX ingress protocol mpls_uc \
     flower mpls lse depth 2 label 256             \
     action drop

 $ tc filter show dev ethX ingress
   filter protocol mpls_uc pref 49152 flower chain 0
   filter protocol mpls_uc pref 49152 flower chain 0 handle 0x1
     eth_type 8847
     mpls
       lse depth 2 label 0  <-- invalid label 0, should be 256
   ...

Fixes: 61aec25a ("cls_flower: Support filtering on multiple MPLS Label Stack Entries")
Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b7e4ba9a

net/sched/cls_flower.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2424,7 +2424,7 @@ static int fl_dump_key_mpls_opt_lse(struct sk_buff *skb,
		return err;
		}
		if (lse_mask->mpls_label) {
		err = nla_put_u8(skb, TCA_FLOWER_KEY_MPLS_OPT_LSE_LABEL,
		err = nla_put_u32(skb, TCA_FLOWER_KEY_MPLS_OPT_LSE_LABEL,
		lse_key->mpls_label);
		if (err)
		return err;