Commit 7fdaf896 authored by Xu Panda's avatar Xu Panda Committed by Marc Kleine-Budde
Browse files

can: ucan: use strscpy() to instead of strncpy() 



The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: default avatarXu Panda <xu.panda@zte.com.cn>
Signed-off-by: default avatarYang Yang <yang.yang29@zte.com>
Link: https://lore.kernel.org/all/202212070909095189693@zte.com.cn


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 5425094a

drivers/net/can/usb/ucan.c

+2 −3
Original line number Diff line number Diff line
@@ -1534,9 +1534,8 @@ static int ucan_probe(struct usb_interface *intf, 
				     sizeof(union ucan_ctl_payload));

	if (ret > 0) {

		/* copy string while ensuring zero termination */

		strncpy(firmware_str, up->ctl_msg_buffer->raw,

			sizeof(union ucan_ctl_payload));

		firmware_str[sizeof(union ucan_ctl_payload)] = '\0';

		strscpy(firmware_str, up->ctl_msg_buffer->raw,

			sizeof(union ucan_ctl_payload) + 1);

	} else {

		strcpy(firmware_str, "unknown");

	}