Commit 7fd069d6 authored by Heikki Krogerus's avatar Heikki Krogerus Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: host: Stop setting the ACPI companion 



It is no longer needed. The sysdev pointer is now used when
assigning the ACPI companions to the xHCI ports and USB
devices.

Assigning the ACPI companion here resulted in the
fwnode->secondary pointer to be replaced also for the parent
dwc3 device since the primary fwnode (the ACPI companion)
was shared. That was unintentional and it created potential
side effects like resource leaks.

Signed-off-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20220428111056.3558-3-heikki.krogerus@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f7ffaa6f

drivers/usb/dwc3/host.c

+0 −2
Original line number Diff line number Diff line
@@ -7,7 +7,6 @@ 
 * Authors: Felipe Balbi <balbi@ti.com>,

 */



#include <linux/acpi.h>

#include <linux/irq.h>

#include <linux/of.h>

#include <linux/platform_device.h>
@@ -83,7 +82,6 @@ int dwc3_host_init(struct dwc3 *dwc) 
	}



	xhci->dev.parent	= dwc->dev;

	ACPI_COMPANION_SET(&xhci->dev, ACPI_COMPANION(dwc->dev));



	dwc->xhci = xhci;