Commit 7fc0b9b9 authored by Tony Luck's avatar Tony Luck Committed by Borislav Petkov
Browse files

EDAC: Drop the EDAC report status checks 



When acpi_extlog was added, we were worried that the same error would
be reported more than once by different subsystems. But in the ensuing
years I've seen complaints that people could not find an error log
(because this mechanism suppressed the log they were looking for).

Rip it all out. People are smart enough to notice the same address from
different reporting mechanisms.

Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
Tested-by: default avatarTony Luck <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/20200214222720.13168-8-tony.luck@intel.com
parent 43505646

drivers/acpi/acpi_extlog.c

+0 −14
Original line number Diff line number Diff line
@@ -42,8 +42,6 @@ struct extlog_l1_head { 
	u8  rev1[12];

};



static int old_edac_report_status;



static u8 extlog_dsm_uuid[] __initdata = "663E35AF-CC10-41A4-88EA-5470AF055295";



/* L1 table related physical address */
@@ -229,11 +227,6 @@ static int __init extlog_init(void) 
	if (!(cap & MCG_ELOG_P) || !extlog_get_l1addr())

		return -ENODEV;



	if (edac_get_report_status() == EDAC_REPORTING_FORCE) {

		pr_warn("Not loading eMCA, error reporting force-enabled through EDAC.\n");

		return -EPERM;

	}



	rc = -EINVAL;

	/* get L1 header to fetch necessary information */

	l1_hdr_size = sizeof(struct extlog_l1_head);
@@ -281,12 +274,6 @@ static int __init extlog_init(void) 
	if (elog_buf == NULL)

		goto err_release_elog;



	/*

	 * eMCA event report method has higher priority than EDAC method,

	 * unless EDAC event report method is mandatory.

	 */

	old_edac_report_status = edac_get_report_status();

	edac_set_report_status(EDAC_REPORTING_DISABLED);

	mce_register_decode_chain(&extlog_mce_dec);

	/* enable OS to be involved to take over management from BIOS */

	((struct extlog_l1_head *)extlog_l1_addr)->flags |= FLAG_OS_OPTIN;
@@ -308,7 +295,6 @@ static int __init extlog_init(void) 


static void __exit extlog_exit(void)

{

	edac_set_report_status(old_edac_report_status);

	mce_unregister_decode_chain(&extlog_mce_dec);

	((struct extlog_l1_head *)extlog_l1_addr)->flags &= ~FLAG_OS_OPTIN;

	if (extlog_l1_addr)

drivers/edac/edac_mc.c

+0 −61
Original line number Diff line number Diff line
@@ -43,8 +43,6 @@ 
int edac_op_state = EDAC_OPSTATE_INVAL;

EXPORT_SYMBOL_GPL(edac_op_state);



static int edac_report = EDAC_REPORTING_ENABLED;



/* lock to memory controller's control array */

static DEFINE_MUTEX(mem_ctls_mutex);

static LIST_HEAD(mc_devices);
@@ -60,65 +58,6 @@ static struct mem_ctl_info *error_desc_to_mci(struct edac_raw_error_desc *e) 
	return container_of(e, struct mem_ctl_info, error_desc);

}



int edac_get_report_status(void)

{

	return edac_report;

}

EXPORT_SYMBOL_GPL(edac_get_report_status);



void edac_set_report_status(int new)

{

	if (new == EDAC_REPORTING_ENABLED ||

	    new == EDAC_REPORTING_DISABLED ||

	    new == EDAC_REPORTING_FORCE)

		edac_report = new;

}

EXPORT_SYMBOL_GPL(edac_set_report_status);



static int edac_report_set(const char *str, const struct kernel_param *kp)

{

	if (!str)

		return -EINVAL;



	if (!strncmp(str, "on", 2))

		edac_report = EDAC_REPORTING_ENABLED;

	else if (!strncmp(str, "off", 3))

		edac_report = EDAC_REPORTING_DISABLED;

	else if (!strncmp(str, "force", 5))

		edac_report = EDAC_REPORTING_FORCE;



	return 0;

}



static int edac_report_get(char *buffer, const struct kernel_param *kp)

{

	int ret = 0;



	switch (edac_report) {

	case EDAC_REPORTING_ENABLED:

		ret = sprintf(buffer, "on");

		break;

	case EDAC_REPORTING_DISABLED:

		ret = sprintf(buffer, "off");

		break;

	case EDAC_REPORTING_FORCE:

		ret = sprintf(buffer, "force");

		break;

	default:

		ret = -EINVAL;

		break;

	}



	return ret;

}



static const struct kernel_param_ops edac_report_ops = {

	.set = edac_report_set,

	.get = edac_report_get,

};



module_param_cb(edac_report, &edac_report_ops, &edac_report, 0644);



unsigned int edac_dimm_info_location(struct dimm_info *dimm, char *buf,

				     unsigned int len)

{

drivers/edac/pnd2_edac.c

+0 −3
Original line number Diff line number Diff line
@@ -1396,9 +1396,6 @@ static int pnd2_mce_check_error(struct notifier_block *nb, unsigned long val, vo 
	struct dram_addr daddr;

	char *type;



	if (edac_get_report_status() == EDAC_REPORTING_DISABLED)

		return NOTIFY_DONE;



	mci = pnd2_mci;

	if (!mci || (mce->kflags & MCE_HANDLED_CEC))

		return NOTIFY_DONE;

drivers/edac/sb_edac.c

+0 −4
Original line number Diff line number Diff line
@@ -3134,8 +3134,6 @@ static int sbridge_mce_check_error(struct notifier_block *nb, unsigned long val, 
	struct mem_ctl_info *mci;

	char *type;



	if (edac_get_report_status() == EDAC_REPORTING_DISABLED)

		return NOTIFY_DONE;

	if (mce->kflags & MCE_HANDLED_CEC)

		return NOTIFY_DONE;
@@ -3526,8 +3524,6 @@ static int __init sbridge_init(void) 


	if (rc >= 0) {

		mce_register_decode_chain(&sbridge_mce_dec);

		if (edac_get_report_status() == EDAC_REPORTING_DISABLED)

			sbridge_printk(KERN_WARNING, "Loading driver, error reporting disabled.\n");

		return 0;

	}

drivers/edac/skx_common.c

+0 −3
Original line number Diff line number Diff line
@@ -574,9 +574,6 @@ int skx_mce_check_error(struct notifier_block *nb, unsigned long val, 
	struct mem_ctl_info *mci;

	char *type;



	if (edac_get_report_status() == EDAC_REPORTING_DISABLED)

		return NOTIFY_DONE;



	if (mce->kflags & MCE_HANDLED_CEC)

		return NOTIFY_DONE;