Commit 7fa5047a authored by Rob Herring's avatar Rob Herring
Browse files

drm: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Reviewed-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Liu Ying <victor.liu@nxp.com> # i.MX bridge
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20230310144705.1542207-1-robh@kernel.org


Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 981f8866

drivers/gpu/drm/bridge/imx/imx8qxp-pixel-link.c

+1 −1
Original line number Diff line number Diff line
@@ -313,7 +313,7 @@ imx8qxp_pixel_link_find_next_bridge(struct imx8qxp_pixel_link *pl) 
		}



		/* specially select the next bridge with companion PXL2DPI */

		if (of_find_property(remote, "fsl,companion-pxl2dpi", NULL))

		if (of_property_present(remote, "fsl,companion-pxl2dpi"))

			bridge_sel = ep_cnt;



		ep_cnt++;

drivers/gpu/drm/drm_mipi_dsi.c

+1 −1
Original line number Diff line number Diff line
@@ -329,7 +329,7 @@ int mipi_dsi_host_register(struct mipi_dsi_host *host) 


	for_each_available_child_of_node(host->dev->of_node, node) {

		/* skip nodes without reg property */

		if (!of_find_property(node, "reg", NULL))

		if (!of_property_present(node, "reg"))

			continue;

		of_mipi_dsi_device_add(host, node);

	}

drivers/gpu/drm/msm/adreno/adreno_gpu.c

+1 −1
Original line number Diff line number Diff line
@@ -964,7 +964,7 @@ static void adreno_get_pwrlevels(struct device *dev, 
	gpu->fast_rate = 0;



	/* You down with OPP? */

	if (!of_find_property(dev->of_node, "operating-points-v2", NULL))

	if (!of_property_present(dev->of_node, "operating-points-v2"))

		ret = adreno_get_legacy_pwrlevels(dev);

	else {

		ret = devm_pm_opp_of_add_table(dev);

drivers/gpu/drm/sun4i/sun4i_backend.c

+1 −1
Original line number Diff line number Diff line
@@ -792,7 +792,7 @@ static int sun4i_backend_bind(struct device *dev, struct device *master, 
	dev_set_drvdata(dev, backend);

	spin_lock_init(&backend->frontend_lock);



	if (of_find_property(dev->of_node, "interconnects", NULL)) {

	if (of_property_present(dev->of_node, "interconnects")) {

		/*

		 * This assume we have the same DMA constraints for all our the

		 * devices in our pipeline (all the backends, but also the

drivers/gpu/drm/sun4i/sun8i_mixer.c

+1 −1
Original line number Diff line number Diff line
@@ -391,7 +391,7 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master, 
	mixer->engine.ops = &sun8i_engine_ops;

	mixer->engine.node = dev->of_node;



	if (of_find_property(dev->of_node, "iommus", NULL)) {

	if (of_property_present(dev->of_node, "iommus")) {

		/*

		 * This assume we have the same DMA constraints for

		 * all our the mixers in our pipeline. This sounds