Commit 7f8d698f authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: rtl8188eu: convert pr_info call to dev_err call ODM_RAStateCheck 



Introduce logic to extract struct device pointer from passed in struct
odm_dm_struct pointer argument, and use this to call dev_err instead of
pr_info. As this is an error state if this line is reached, this is not
just information. Also, this is a driver, so dev_err is more
appropriate.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210525214813.6362-1-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 993b21a0

drivers/staging/rtl8188eu/hal/odm.c

+2 −1
Original line number Diff line number Diff line
@@ -808,6 +808,7 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate 
	u8 HighRSSIThreshForRA = pRA->HighRSSIThresh;

	u8 LowRSSIThreshForRA = pRA->LowRSSIThresh;

	u8 RATRState;

	struct device *dev = dvobj_to_dev(adapter_to_dvobj(pDM_Odm->Adapter));



	/*  Threshold Adjustment: */

	/*  when RSSI state trends to go up one or two levels, make sure RSSI is high enough. */
@@ -824,7 +825,7 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate 
		LowRSSIThreshForRA += GoUpGap;

		break;

	default:

		pr_info("%s(): wrong rssi level setting %d!\n", __func__, *pRATRState);

		dev_err(dev, "%s(): wrong rssi level setting %d!\n", __func__, *pRATRState);

		break;

	}