Commit 7f83773c authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Matt Fleming
Browse files

efi/esrt: Don't preformat name 



kobject_init_and_add takes a format string+args, so there's no reason
to do this formatting in advance.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Peter Jones <pjones@redhat.com>
Signed-off-by: default avatarMatt Fleming <matt@codeblueprint.co.uk>
parent 8005c49d

drivers/firmware/efi/esrt.c

+1 −4
Original line number Diff line number Diff line
@@ -167,14 +167,11 @@ static struct kset *esrt_kset; 
static int esre_create_sysfs_entry(void *esre, int entry_num)

{

	struct esre_entry *entry;

	char name[20];



	entry = kzalloc(sizeof(*entry), GFP_KERNEL);

	if (!entry)

		return -ENOMEM;



	sprintf(name, "entry%d", entry_num);



	entry->kobj.kset = esrt_kset;



	if (esrt->fw_resource_version == 1) {
@@ -182,7 +179,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num) 


		entry->esre.esre1 = esre;

		rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,

					  "%s", name);

					  "entry%d", entry_num);

		if (rc) {

			kfree(entry);

			return rc;