Commit 7f57b295 authored by Qinglang Miao's avatar Qinglang Miao Committed by Bartosz Golaszewski
Browse files

gpio: zynq: fix reference leak in zynq_gpio functions 



pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to putting operation will result in a
reference leak here.

A new function pm_runtime_resume_and_get is introduced in
[0] to keep usage counter balanced. So We fix the reference
leak by replacing it with new funtion.

[0] dd8088d5 ("PM: runtime: Add  pm_runtime_resume_and_get to deal with usage counter")

Fixes: c2df3de0 ("gpio: zynq: properly support runtime PM for GPIO used as interrupts")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 6dbbf846

drivers/gpio/gpio-zynq.c

+2 −2
Original line number Diff line number Diff line
@@ -574,7 +574,7 @@ static int zynq_gpio_irq_reqres(struct irq_data *d) 
	struct gpio_chip *chip = irq_data_get_irq_chip_data(d);

	int ret;



	ret = pm_runtime_get_sync(chip->parent);

	ret = pm_runtime_resume_and_get(chip->parent);

	if (ret < 0)

		return ret;
@@ -942,7 +942,7 @@ static int zynq_gpio_probe(struct platform_device *pdev) 


	pm_runtime_set_active(&pdev->dev);

	pm_runtime_enable(&pdev->dev);

	ret = pm_runtime_get_sync(&pdev->dev);

	ret = pm_runtime_resume_and_get(&pdev->dev);

	if (ret < 0)

		goto err_pm_dis;