Commit 7f2e65a8 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Wolfram Sang
Browse files

i2c: qcom-cci: Fix error checking in cci_probe() 



devm_clk_bulk_get_all() can return zero when no clocks are obtained.
Passing zero to dev_err_probe() is a success which is incorrect.

Fixes: 605efbf4 ("i2c: qcom-cci: Use dev_err_probe in probe function")
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: default avatarAndi Shyti <andi.shyti@kernel.org>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 6c30ac91

drivers/i2c/busses/i2c-qcom-cci.c

+3 −1
Original line number Diff line number Diff line
@@ -588,8 +588,10 @@ static int cci_probe(struct platform_device *pdev) 
	/* Clocks */



	ret = devm_clk_bulk_get_all(dev, &cci->clocks);

	if (ret < 1)

	if (ret < 0)

		return dev_err_probe(dev, ret, "failed to get clocks\n");

	else if (!ret)

		return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n");

	cci->nclocks = ret;



	/* Retrieve CCI clock rate */