Commit 7f1e215b authored by Qinglang Miao's avatar Qinglang Miao Committed by Kalle Valo
Browse files

mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE 



Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Acked-by: default avatarJakub Kicinski <kubakici@wp.pl>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200919024838.14172-1-miaoqinglang@huawei.com
parent d0c8ff7c

drivers/net/wireless/mediatek/mt7601u/debugfs.c

+6 −28
Original line number Diff line number Diff line
@@ -30,7 +30,7 @@ mt76_reg_get(void *data, u64 *val) 
DEFINE_DEBUGFS_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, "0x%08llx\n");



static int

mt7601u_ampdu_stat_read(struct seq_file *file, void *data)

mt7601u_ampdu_stat_show(struct seq_file *file, void *data)

{

	struct mt7601u_dev *dev = file->private;

	int i, j;
@@ -73,21 +73,10 @@ mt7601u_ampdu_stat_read(struct seq_file *file, void *data) 
	return 0;

}



static int

mt7601u_ampdu_stat_open(struct inode *inode, struct file *f)

{

	return single_open(f, mt7601u_ampdu_stat_read, inode->i_private);

}



static const struct file_operations fops_ampdu_stat = {

	.open = mt7601u_ampdu_stat_open,

	.read = seq_read,

	.llseek = seq_lseek,

	.release = single_release,

};

DEFINE_SHOW_ATTRIBUTE(mt7601u_ampdu_stat);



static int

mt7601u_eeprom_param_read(struct seq_file *file, void *data)

mt7601u_eeprom_param_show(struct seq_file *file, void *data)

{

	struct mt7601u_dev *dev = file->private;

	struct mt7601u_rate_power *rp = &dev->ee->power_rate_table;
@@ -131,18 +120,7 @@ mt7601u_eeprom_param_read(struct seq_file *file, void *data) 
	return 0;

}



static int

mt7601u_eeprom_param_open(struct inode *inode, struct file *f)

{

	return single_open(f, mt7601u_eeprom_param_read, inode->i_private);

}



static const struct file_operations fops_eeprom_param = {

	.open = mt7601u_eeprom_param_open,

	.read = seq_read,

	.llseek = seq_lseek,

	.release = single_release,

};

DEFINE_SHOW_ATTRIBUTE(mt7601u_eeprom_param);



void mt7601u_init_debugfs(struct mt7601u_dev *dev)

{
@@ -157,6 +135,6 @@ void mt7601u_init_debugfs(struct mt7601u_dev *dev) 


	debugfs_create_u32("regidx", 0600, dir, &dev->debugfs_reg);

	debugfs_create_file("regval", 0600, dir, dev, &fops_regval);

	debugfs_create_file("ampdu_stat", 0400, dir, dev, &fops_ampdu_stat);

	debugfs_create_file("eeprom_param", 0400, dir, dev, &fops_eeprom_param);

	debugfs_create_file("ampdu_stat", 0400, dir, dev, &mt7601u_ampdu_stat_fops);

	debugfs_create_file("eeprom_param", 0400, dir, dev, &mt7601u_eeprom_param_fops);

}