Commit 7f0f1ea0 authored Jul 03, 2023 by Ahelenia Ziemiańska Committed by Christian Brauner Jul 10, 2023

splice: fsnotify_access(fd)/fsnotify_modify(fd) in vmsplice

Same logic applies here: this can fill up the pipe and pollers that rely
on getting IN_MODIFY notifications never wake up.

Fixes: 983652c6 ("splice: report related fsnotify events")
Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u
Link: https://bugs.debian.org/1039488

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Acked-by: Jan Kara <jack@suse.cz>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Message-Id: <8d9ad5acb9c5c1dd2376a2ff5da6ac3183115389.1688393619.git.nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Christian Brauner <brauner@kernel.org>

parent 12ee4b66

fs/splice.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1460,6 +1460,9 @@ static long vmsplice_to_user(struct file file, struct iov_iter iter,
		pipe_unlock(pipe);
		}

		if (ret > 0)
		fsnotify_access(file);

		return ret;
		}

		@@ -1489,8 +1492,10 @@ static long vmsplice_to_pipe(struct file file, struct iov_iter iter,
		if (!ret)
		ret = iter_to_pipe(iter, pipe, buf_flag);
		pipe_unlock(pipe);
		if (ret > 0)
		if (ret > 0) {
		wakeup_pipe_readers(pipe);
		fsnotify_modify(file);
		}
		return ret;
		}