Commit 7ebb8d06 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Boris Brezillon
Browse files

mtd: nand: denali: return error code from devm_request_irq() on error 



The devm_request_irq() returns an appropriate error value when it
fails.  Use it instead of the fixed -ENODEV.

While we are here, reword the comment to make it fit in a single
line, fixing the misspelling of "initialization".

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: default avatarMarek Vasut <marek.vasut@gmail.com>
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
parent c1d0df19

drivers/mtd/nand/denali.c

+5 −7
Original line number Diff line number Diff line
@@ -1451,14 +1451,12 @@ int denali_init(struct denali_nand_info *denali) 
	denali_hw_init(denali);

	denali_drv_init(denali);



	/*

	 * denali_isr register is done after all the hardware

	 * initilization is finished

	 */

	if (devm_request_irq(denali->dev, denali->irq, denali_isr, IRQF_SHARED,

			     DENALI_NAND_NAME, denali)) {

	/* Request IRQ after all the hardware initialization is finished */

	ret = devm_request_irq(denali->dev, denali->irq, denali_isr,

			       IRQF_SHARED, DENALI_NAND_NAME, denali);

	if (ret) {

		dev_err(denali->dev, "Unable to request IRQ\n");

		return -ENODEV;

		return ret;

	}



	/* now that our ISR is registered, we can enable interrupts */