Commit 7eb060a5 authored by Pedro Tammela's avatar Pedro Tammela Committed by David S. Miller
Browse files

selftests: tc-testing: add more tests for sch_qfq 



The QFQ qdisc class has parameter bounds that are not being
checked for correctness.

Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarPedro Tammela <pctammela@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 25369891

tools/testing/selftests/tc-testing/tc-tests/qdiscs/qfq.json

+72 −0
Original line number Diff line number Diff line
@@ -46,6 +46,30 @@ 
            "$IP link del dev $DUMMY type dummy"

        ]

    },

    {

        "id": "d364",

        "name": "Test QFQ with max class weight setting",

        "category": [

            "qdisc",

            "qfq"

        ],

        "plugins": {

            "requires": "nsPlugin"

        },

        "setup": [

            "$IP link add dev $DUMMY type dummy || /bin/true",

            "$TC qdisc add dev $DUMMY handle 1: root qfq"

        ],

        "cmdUnderTest": "$TC class add dev $DUMMY parent 1: classid 1:1 qfq weight 9999",

        "expExitCode": "2",

        "verifyCmd": "$TC class show dev $DUMMY",

        "matchPattern": "class qfq 1:1 root weight 9999 maxpkt",

        "matchCount": "0",

        "teardown": [

            "$TC qdisc del dev $DUMMY handle 1: root",

            "$IP link del dev $DUMMY type dummy"

        ]

    },

    {

        "id": "8452",

        "name": "Create QFQ with class maxpkt setting",
@@ -70,6 +94,54 @@ 
            "$IP link del dev $DUMMY type dummy"

        ]

    },

    {

        "id": "22df",

        "name": "Test QFQ class maxpkt setting lower bound",

        "category": [

            "qdisc",

            "qfq"

        ],

        "plugins": {

            "requires": "nsPlugin"

        },

        "setup": [

            "$IP link add dev $DUMMY type dummy || /bin/true",

            "$TC qdisc add dev $DUMMY handle 1: root qfq"

        ],

        "cmdUnderTest": "$TC class add dev $DUMMY parent 1: classid 1:1 qfq maxpkt 128",

        "expExitCode": "2",

        "verifyCmd": "$TC class show dev $DUMMY",

        "matchPattern": "class qfq 1:1 root weight 1 maxpkt 128",

        "matchCount": "0",

        "teardown": [

            "$TC qdisc del dev $DUMMY handle 1: root",

            "$IP link del dev $DUMMY type dummy"

        ]

    },

    {

        "id": "92ee",

        "name": "Test QFQ class maxpkt setting upper bound",

        "category": [

            "qdisc",

            "qfq"

        ],

        "plugins": {

            "requires": "nsPlugin"

        },

        "setup": [

            "$IP link add dev $DUMMY type dummy || /bin/true",

            "$TC qdisc add dev $DUMMY handle 1: root qfq"

        ],

        "cmdUnderTest": "$TC class add dev $DUMMY parent 1: classid 1:1 qfq maxpkt 99999",

        "expExitCode": "2",

        "verifyCmd": "$TC class show dev $DUMMY",

        "matchPattern": "class qfq 1:1 root weight 1 maxpkt 99999",

        "matchCount": "0",

        "teardown": [

            "$TC qdisc del dev $DUMMY handle 1: root",

            "$IP link del dev $DUMMY type dummy"

        ]

    },

    {

        "id": "d920",

        "name": "Create QFQ with multiple class setting",