Commit 7ea03ab7 authored by Vaibhav Gupta's avatar Vaibhav Gupta Committed by Martin K. Petersen
Browse files

scsi: 3w-sas: Drop PCI Wakeup calls from .resume 

The driver calls pci_enable_wake(...., false) in twl_resume(), and there is
no corresponding pci_enable_wake(...., true) in twl_suspend().  Either it
should do enable-wake the device in .suspend() or should not invoke
pci_enable_wake() at all.

Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
twl_resume().

Link: https://lore.kernel.org/r/20201102164730.324035-24-vaibhavgupta40@gmail.com


Signed-off-by: default avatarVaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d53ae6bb

drivers/scsi/3w-sas.c

+0 −1
Original line number Diff line number Diff line
@@ -1795,7 +1795,6 @@ static int twl_resume(struct pci_dev *pdev) 


	printk(KERN_WARNING "3w-sas: Resuming host %d.\n", tw_dev->host->host_no);

	pci_set_power_state(pdev, PCI_D0);

	pci_enable_wake(pdev, PCI_D0, 0);

	pci_restore_state(pdev);



	retval = pci_enable_device(pdev);