Commit 7e9be673 authored by zhouchuangao's avatar zhouchuangao Committed by Thomas Bogendoerfer
Browse files

MIPS: BCM63XX: Use BUG_ON instead of condition followed by BUG. 



BUG_ON uses unlikely in if(), it can be optimized at compile time.

Usually, the condition in if() is not satisfied. In my opinion,
this can improve the efficiency of the multi-stage pipeline.

Signed-off-by: default avatarzhouchuangao <zhouchuangao@vivo.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent c55944cc

arch/mips/bcm63xx/gpio.c

+3 −6
Original line number Diff line number Diff line
@@ -43,8 +43,7 @@ static void bcm63xx_gpio_set(struct gpio_chip *chip, 
	u32 *v;

	unsigned long flags;



	if (gpio >= chip->ngpio)

		BUG();

	BUG_ON(gpio >= chip->ngpio);



	if (gpio < 32) {

		reg = gpio_out_low_reg;
@@ -70,8 +69,7 @@ static int bcm63xx_gpio_get(struct gpio_chip *chip, unsigned gpio) 
	u32 reg;

	u32 mask;



	if (gpio >= chip->ngpio)

		BUG();

	BUG_ON(gpio >= chip->ngpio);



	if (gpio < 32) {

		reg = gpio_out_low_reg;
@@ -92,8 +90,7 @@ static int bcm63xx_gpio_set_direction(struct gpio_chip *chip, 
	u32 tmp;

	unsigned long flags;



	if (gpio >= chip->ngpio)

		BUG();

	BUG_ON(gpio >= chip->ngpio);



	if (gpio < 32) {

		reg = GPIO_CTL_LO_REG;