Commit 7e85c41b authored by Li Nan's avatar Li Nan Committed by Song Liu
Browse files

md/raid10: check replacement and rdev to prevent submit the same io twice 



After commit 4ca40c2c ("md/raid10: Allow replacement device to be
replace old drive."), 'rdev' and 'replacement' could appear to be
identical. There are already checks for that in wait_blocked_dev() and
raid10_write_request(). Add check for raid10_handle_discard() now.

Signed-off-by: default avatarLi Nan <linan122@huawei.com>
Link: https://lore.kernel.org/r/20230701080529.2684932-2-linan666@huaweicloud.com


Signed-off-by: default avatarSong Liu <song@kernel.org>
parent 21bd9a68

drivers/md/raid10.c

+2 −0
Original line number Diff line number Diff line
@@ -1785,6 +1785,8 @@ static int raid10_handle_discard(struct mddev *mddev, struct bio *bio) 
		r10_bio->devs[disk].bio = NULL;

		r10_bio->devs[disk].repl_bio = NULL;



		if (rdev == rrdev)

			rrdev = NULL;

		if (rdev && (test_bit(Faulty, &rdev->flags)))

			rdev = NULL;

		if (rrdev && (test_bit(Faulty, &rrdev->flags)))