Commit 7e6f7f3a authored by Dan Murphy's avatar Dan Murphy Committed by Pavel Machek
Browse files

leds: lp55xx: Fix file permissions to use DEVICE_ATTR macros 



Fix the checkpatch warnings for the use of the file permission macros.
In converting the file permissions to the DEVICE_ATTR_XX macros the
call back function names needed to be updated within the code.

This means that the lp55xx_ needed to be dropped in the name to keep in
harmony with the ABI documentation.

Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Acked-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: default avatarDan Murphy <dmurphy@ti.com>
Reviewed-by: default avatarMarek Behún <marek.behun@nic.cz>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent cf1a1a6a

drivers/leds/leds-lp55xx-common.c

+10 −12
Original line number Diff line number Diff line
@@ -77,7 +77,7 @@ static int lp55xx_post_init_device(struct lp55xx_chip *chip) 
	return cfg->post_init_device(chip);

}



static ssize_t lp55xx_show_current(struct device *dev,

static ssize_t led_current_show(struct device *dev,

			    struct device_attribute *attr,

			    char *buf)

{
@@ -86,7 +86,7 @@ static ssize_t lp55xx_show_current(struct device *dev, 
	return scnprintf(buf, PAGE_SIZE, "%d\n", led->led_current);

}



static ssize_t lp55xx_store_current(struct device *dev,

static ssize_t led_current_store(struct device *dev,

			     struct device_attribute *attr,

			     const char *buf, size_t len)

{
@@ -110,7 +110,7 @@ static ssize_t lp55xx_store_current(struct device *dev, 
	return len;

}



static ssize_t lp55xx_show_max_current(struct device *dev,

static ssize_t max_current_show(struct device *dev,

			    struct device_attribute *attr,

			    char *buf)

{
@@ -119,9 +119,8 @@ static ssize_t lp55xx_show_max_current(struct device *dev, 
	return scnprintf(buf, PAGE_SIZE, "%d\n", led->max_current);

}



static DEVICE_ATTR(led_current, S_IRUGO | S_IWUSR, lp55xx_show_current,

		lp55xx_store_current);

static DEVICE_ATTR(max_current, S_IRUGO , lp55xx_show_max_current, NULL);

static DEVICE_ATTR_RW(led_current);

static DEVICE_ATTR_RO(max_current);



static struct attribute *lp55xx_led_attrs[] = {

	&dev_attr_led_current.attr,
@@ -224,7 +223,7 @@ static int lp55xx_request_firmware(struct lp55xx_chip *chip) 
				GFP_KERNEL, chip, lp55xx_firmware_loaded);

}



static ssize_t lp55xx_show_engine_select(struct device *dev,

static ssize_t select_engine_show(struct device *dev,

			    struct device_attribute *attr,

			    char *buf)

{
@@ -234,7 +233,7 @@ static ssize_t lp55xx_show_engine_select(struct device *dev, 
	return sprintf(buf, "%d\n", chip->engine_idx);

}



static ssize_t lp55xx_store_engine_select(struct device *dev,

static ssize_t select_engine_store(struct device *dev,

			     struct device_attribute *attr,

			     const char *buf, size_t len)

{
@@ -276,7 +275,7 @@ static inline void lp55xx_run_engine(struct lp55xx_chip *chip, bool start) 
		chip->cfg->run_engine(chip, start);

}



static ssize_t lp55xx_store_engine_run(struct device *dev,

static ssize_t run_engine_store(struct device *dev,

			     struct device_attribute *attr,

			     const char *buf, size_t len)

{
@@ -301,9 +300,8 @@ static ssize_t lp55xx_store_engine_run(struct device *dev, 
	return len;

}



static DEVICE_ATTR(select_engine, S_IRUGO | S_IWUSR,

		   lp55xx_show_engine_select, lp55xx_store_engine_select);

static DEVICE_ATTR(run_engine, S_IWUSR, NULL, lp55xx_store_engine_run);

static DEVICE_ATTR_RW(select_engine);

static DEVICE_ATTR_WO(run_engine);



static struct attribute *lp55xx_engine_attributes[] = {

	&dev_attr_select_engine.attr,