Commit 7e021809 authored by Wang Chen's avatar Wang Chen Committed by David S. Miller
Browse files

[LLC]: Use proc_create() to setup ->proc_fops first 



Use proc_create() to make sure that ->proc_fops be setup before gluing
PDE to main tree.

Signed-off-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1e15dc98

net/llc/llc_proc.c

+2 −6
Original line number Diff line number Diff line
@@ -239,18 +239,14 @@ int __init llc_proc_init(void) 
		goto out;

	llc_proc_dir->owner = THIS_MODULE;



	p = create_proc_entry("socket", S_IRUGO, llc_proc_dir);

	p = proc_create("socket", S_IRUGO, llc_proc_dir, &llc_seq_socket_fops);

	if (!p)

		goto out_socket;



	p->proc_fops = &llc_seq_socket_fops;



	p = create_proc_entry("core", S_IRUGO, llc_proc_dir);

	p = proc_create("core", S_IRUGO, llc_proc_dir, &llc_seq_core_fops);

	if (!p)

		goto out_core;



	p->proc_fops = &llc_seq_core_fops;



	rc = 0;

out:

	return rc;