Commit 7de5f68d authored by Eric W. Biederman's avatar Eric W. Biederman
Browse files

signal/alpha: si_trapno is only used with SIGFPE and SIGTRAP TRAP_UNK 

While reviewing the signal handlers on alpha it became clear that
si_trapno is only set to a non-zero value when sending SIGFPE and when
sending SITGRAP with si_code TRAP_UNK.

Add send_sig_fault_trapno and send SIGTRAP TRAP_UNK, and SIGFPE with it.

Remove the define of __ARCH_SI_TRAPNO and remove the always zero
si_trapno parameter from send_sig_fault and force_sig_fault.

v1: https://lkml.kernel.org/r/m1eeers7q7.fsf_-_@fess.ebiederm.org
v2: https://lkml.kernel.org/r/20210505141101.11519-7-ebiederm@xmission.com
Link: https://lkml.kernel.org/r/87h7gvxx7l.fsf_-_@disp2133


Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
parent 2c9f7eaf

arch/alpha/include/uapi/asm/siginfo.h

+0 −2
Original line number Diff line number Diff line
@@ -2,8 +2,6 @@ 
#ifndef _ALPHA_SIGINFO_H

#define _ALPHA_SIGINFO_H



#define __ARCH_SI_TRAPNO



#include <asm-generic/siginfo.h>



#endif

arch/alpha/kernel/osf_sys.c

+1 −1
Original line number Diff line number Diff line
@@ -876,7 +876,7 @@ SYSCALL_DEFINE5(osf_setsysinfo, unsigned long, op, void __user *, buffer, 
			if (fex & IEEE_TRAP_ENABLE_DZE) si_code = FPE_FLTDIV;

			if (fex & IEEE_TRAP_ENABLE_INV) si_code = FPE_FLTINV;



			send_sig_fault(SIGFPE, si_code,

			send_sig_fault_trapno(SIGFPE, si_code,

				       (void __user *)NULL,  /* FIXME */

				       0, current);

 		}

arch/alpha/kernel/signal.c

+2 −2
Original line number Diff line number Diff line
@@ -219,7 +219,7 @@ do_sigreturn(struct sigcontext __user *sc) 


	/* Send SIGTRAP if we're single-stepping: */

	if (ptrace_cancel_bpt (current)) {

		send_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *) regs->pc, 0,

		send_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *) regs->pc,

			       current);

	}

	return;
@@ -247,7 +247,7 @@ do_rt_sigreturn(struct rt_sigframe __user *frame) 


	/* Send SIGTRAP if we're single-stepping: */

	if (ptrace_cancel_bpt (current)) {

		send_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *) regs->pc, 0,

		send_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *) regs->pc,

			       current);

	}

	return;

arch/alpha/kernel/traps.c

+13 −13
Original line number Diff line number Diff line
@@ -227,7 +227,7 @@ do_entArith(unsigned long summary, unsigned long write_mask, 
	}

	die_if_kernel("Arithmetic fault", regs, 0, NULL);



	send_sig_fault(SIGFPE, si_code, (void __user *) regs->pc, 0, current);

	send_sig_fault_trapno(SIGFPE, si_code, (void __user *) regs->pc, 0, current);

}



asmlinkage void
@@ -268,13 +268,13 @@ do_entIF(unsigned long type, struct pt_regs *regs) 
			regs->pc -= 4;	/* make pc point to former bpt */

		}



		send_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *)regs->pc, 0,

		send_sig_fault(SIGTRAP, TRAP_BRKPT, (void __user *)regs->pc,

			       current);

		return;



	      case 1: /* bugcheck */

		send_sig_fault(SIGTRAP, TRAP_UNK, (void __user *) regs->pc, 0,

			       current);

		send_sig_fault_trapno(SIGTRAP, TRAP_UNK,

				      (void __user *) regs->pc, 0, current);

		return;

		

	      case 2: /* gentrap */
@@ -335,8 +335,8 @@ do_entIF(unsigned long type, struct pt_regs *regs) 
			break;

		}



		send_sig_fault(signo, code, (void __user *) regs->pc, regs->r16,

			       current);

		send_sig_fault_trapno(signo, code, (void __user *) regs->pc,

				      regs->r16, current);

		return;



	      case 4: /* opDEC */
@@ -360,9 +360,9 @@ do_entIF(unsigned long type, struct pt_regs *regs) 
			if (si_code == 0)

				return;

			if (si_code > 0) {

				send_sig_fault(SIGFPE, si_code,

					       (void __user *) regs->pc, 0,

					       current);

				send_sig_fault_trapno(SIGFPE, si_code,

						      (void __user *) regs->pc,

						      0, current);

				return;

			}

		}
@@ -387,7 +387,7 @@ do_entIF(unsigned long type, struct pt_regs *regs) 
		      ;

	}



	send_sig_fault(SIGILL, ILL_ILLOPC, (void __user *)regs->pc, 0, current);

	send_sig_fault(SIGILL, ILL_ILLOPC, (void __user *)regs->pc, current);

}



/* There is an ifdef in the PALcode in MILO that enables a
@@ -402,7 +402,7 @@ do_entDbg(struct pt_regs *regs) 
{

	die_if_kernel("Instruction fault", regs, 0, NULL);



	force_sig_fault(SIGILL, ILL_ILLOPC, (void __user *)regs->pc, 0);

	force_sig_fault(SIGILL, ILL_ILLOPC, (void __user *)regs->pc);

}
@@ -964,12 +964,12 @@ do_entUnaUser(void __user * va, unsigned long opcode, 
			si_code = SEGV_MAPERR;

		mmap_read_unlock(mm);

	}

	send_sig_fault(SIGSEGV, si_code, va, 0, current);

	send_sig_fault(SIGSEGV, si_code, va, current);

	return;



give_sigbus:

	regs->pc -= 4;

	send_sig_fault(SIGBUS, BUS_ADRALN, va, 0, current);

	send_sig_fault(SIGBUS, BUS_ADRALN, va, current);

	return;

}

arch/alpha/mm/fault.c

+2 −2
Original line number Diff line number Diff line
@@ -219,13 +219,13 @@ do_page_fault(unsigned long address, unsigned long mmcsr, 
	mmap_read_unlock(mm);

	/* Send a sigbus, regardless of whether we were in kernel

	   or user mode.  */

	force_sig_fault(SIGBUS, BUS_ADRERR, (void __user *) address, 0);

	force_sig_fault(SIGBUS, BUS_ADRERR, (void __user *) address);

	if (!user_mode(regs))

		goto no_context;

	return;



 do_sigsegv:

	force_sig_fault(SIGSEGV, si_code, (void __user *) address, 0);

	force_sig_fault(SIGSEGV, si_code, (void __user *) address);

	return;



#ifdef CONFIG_ALPHA_LARGE_VMALLOC