Commit 7dcd026f authored by Naveen Naidu's avatar Naveen Naidu Committed by Bjorn Helgaas
Browse files

PCI: kirin: Drop error data fabrication when config read fails 

If config pci_ops.read() methods return failure, the PCI_OP_READ() and
PCI_USER_READ_CONFIG() wrappers use PCI_SET_ERROR_RESPONSE() to set the
data value, so there's no need to set it in the pci_ops.read() methods
themselves.

Drop the unnecessary data value fabrication when pci_ops.read() fails.

Link: https://lore.kernel.org/r/f87e22bc09a471d2cf15ad05dfd6432f57739aed.1637243717.git.naveennaidu479@gmail.com


Signed-off-by: default avatarNaveen Naidu <naveennaidu479@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent f4a44c1e

drivers/pci/controller/dwc/pcie-kirin.c

+1 −3
Original line number Diff line number Diff line
@@ -530,10 +530,8 @@ static int kirin_pcie_rd_own_conf(struct pci_bus *bus, unsigned int devfn, 
{

	struct dw_pcie *pci = to_dw_pcie_from_pp(bus->sysdata);



	if (PCI_SLOT(devfn)) {

		*val = ~0;

	if (PCI_SLOT(devfn))

		return PCIBIOS_DEVICE_NOT_FOUND;

	}



	*val = dw_pcie_read_dbi(pci, where, size);

	return PCIBIOS_SUCCESSFUL;