Commit 7dcc683d authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Martin K. Petersen
Browse files

scsi: lpfc: Fix the NULL vs IS_ERR() bug for debugfs_create_file() 



Since debugfs_create_file() returns ERR_PTR and never NULL, use IS_ERR() to
check the return value.

Fixes: 2fcbc569 ("scsi: lpfc: Make debugfs ktime stats generic for NVME and SCSI")
Fixes: 4c47efc1 ("scsi: lpfc: Move SCSI and NVME Stats to hardware queue structures")
Fixes: 6a828b0f ("scsi: lpfc: Support non-uniform allocation of MSIX vectors to hardware queues")
Fixes: 95bfc6d8 ("scsi: lpfc: Make FW logging dynamically configurable")
Fixes: 9f778708 ("scsi: lpfc: Add debugfs support for cm framework buffers")
Fixes: c490850a ("scsi: lpfc: Adapt partitioned XRI lists to efficient sharing")
Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20230906030809.2847970-1-ruanjinjie@huawei.com


Reviewed-by: default avatarJustin Tee <justin.tee@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d14e3e55

drivers/scsi/lpfc/lpfc_debugfs.c

+7 −7
Original line number Diff line number Diff line
@@ -6073,7 +6073,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
					    phba->hba_debugfs_root,

					    phba,

					    &lpfc_debugfs_op_multixripools);

		if (!phba->debug_multixri_pools) {

		if (IS_ERR(phba->debug_multixri_pools)) {

			lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,

					 "0527 Cannot create debugfs multixripools\n");

			goto debug_failed;
@@ -6085,7 +6085,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
			debugfs_create_file(name, S_IFREG | 0644,

					    phba->hba_debugfs_root,

					    phba, &lpfc_cgn_buffer_op);

		if (!phba->debug_cgn_buffer) {

		if (IS_ERR(phba->debug_cgn_buffer)) {

			lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,

					 "6527 Cannot create debugfs "

					 "cgn_buffer\n");
@@ -6098,7 +6098,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
			debugfs_create_file(name, S_IFREG | 0644,

					    phba->hba_debugfs_root,

					    phba, &lpfc_rx_monitor_op);

		if (!phba->debug_rx_monitor) {

		if (IS_ERR(phba->debug_rx_monitor)) {

			lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,

					 "6528 Cannot create debugfs "

					 "rx_monitor\n");
@@ -6111,7 +6111,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
			debugfs_create_file(name, 0644,

					    phba->hba_debugfs_root,

					    phba, &lpfc_debugfs_ras_log);

		if (!phba->debug_ras_log) {

		if (IS_ERR(phba->debug_ras_log)) {

			lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,

					 "6148 Cannot create debugfs"

					 " ras_log\n");
@@ -6132,7 +6132,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
			debugfs_create_file(name, S_IFREG | 0644,

					    phba->hba_debugfs_root,

					    phba, &lpfc_debugfs_op_lockstat);

		if (!phba->debug_lockstat) {

		if (IS_ERR(phba->debug_lockstat)) {

			lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,

					 "4610 Can't create debugfs lockstat\n");

			goto debug_failed;
@@ -6358,7 +6358,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
		debugfs_create_file(name, 0644,

				    vport->vport_debugfs_root,

				    vport, &lpfc_debugfs_op_scsistat);

	if (!vport->debug_scsistat) {

	if (IS_ERR(vport->debug_scsistat)) {

		lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,

				 "4611 Cannot create debugfs scsistat\n");

		goto debug_failed;
@@ -6369,7 +6369,7 @@ lpfc_debugfs_initialize(struct lpfc_vport *vport) 
		debugfs_create_file(name, 0644,

				    vport->vport_debugfs_root,

				    vport, &lpfc_debugfs_op_ioktime);

	if (!vport->debug_ioktime) {

	if (IS_ERR(vport->debug_ioktime)) {

		lpfc_printf_vlog(vport, KERN_ERR, LOG_INIT,

				 "0815 Cannot create debugfs ioktime\n");

		goto debug_failed;