Commit 7dc0f671 authored by Saurav Kashyap's avatar Saurav Kashyap Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Correct the check for sscanf() return value 

Since the version string has been modified, sscanf() returns 4 instead of
6.

Link: https://lore.kernel.org/r/20200929102152.32278-2-njavali@marvell.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarSaurav Kashyap <skashyap@marvell.com>
Signed-off-by: default avatarNilesh Javali <njavali@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 2dd39fad

drivers/scsi/qla2xxx/qla_tmpl.c

+2 −2
Original line number Diff line number Diff line
@@ -906,8 +906,8 @@ qla27xx_driver_info(struct qla27xx_fwdt_template *tmp) 
	uint8_t v[] = { 0, 0, 0, 0, 0, 0 };



	WARN_ON_ONCE(sscanf(qla2x00_version_str,

			    "%hhu.%hhu.%hhu.%hhu.%hhu.%hhu",

			    v+0, v+1, v+2, v+3, v+4, v+5) != 6);

			    "%hhu.%hhu.%hhu.%hhu",

			    v + 0, v + 1, v + 2, v + 3) != 4);



	tmp->driver_info[0] = cpu_to_le32(

		v[3] << 24 | v[2] << 16 | v[1] << 8 | v[0]);