Commit 7da413a1 authored by Allen Pais's avatar Allen Pais Committed by Kalle Valo
Browse files

libertas: fix a potential NULL pointer dereference 



alloc_workqueue is not checked for errors and as a result,
a potential NULL dereference could occur.

Signed-off-by: default avatarAllen Pais <allen.pais@oracle.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent a0d46f7a

drivers/net/wireless/marvell/libertas/if_sdio.c

+5 −0
Original line number Diff line number Diff line
@@ -1179,6 +1179,10 @@ static int if_sdio_probe(struct sdio_func *func, 


	spin_lock_init(&card->lock);

	card->workqueue = alloc_workqueue("libertas_sdio", WQ_MEM_RECLAIM, 0);

	if (unlikely(!card->workqueue)) {

		ret = -ENOMEM;

		goto err_queue;

	}

	INIT_WORK(&card->packet_worker, if_sdio_host_to_card_worker);

	init_waitqueue_head(&card->pwron_waitq);
@@ -1230,6 +1234,7 @@ static int if_sdio_probe(struct sdio_func *func, 
	lbs_remove_card(priv);

free:

	destroy_workqueue(card->workqueue);

err_queue:

	while (card->packets) {

		packet = card->packets;

		card->packets = card->packets->next;