Commit 7d6c86e3 authored by Alaa Hleihel's avatar Alaa Hleihel Committed by Saeed Mahameed
Browse files

net/mlx5e: Allow to match on MPLS parameters only for MPLS over UDP 



Currently, we support hardware offload only for MPLS over UDP.
However, rules matching on MPLS parameters are now wrongly offloaded
for regular MPLS, without actually taking the parameters into
consideration when doing the offload.
Fix it by rejecting such unsupported rules.

Fixes: 72046a91 ("net/mlx5e: Allow to match on mpls parameters")
Signed-off-by: default avatarAlaa Hleihel <alaa@nvidia.com>
Reviewed-by: default avatarRoi Dayan <roid@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent a0723108

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+10 −0
Original line number Diff line number Diff line
@@ -2296,6 +2296,16 @@ static int __parse_cls_flower(struct mlx5e_priv *priv, 
			*match_level = MLX5_MATCH_L4;

	}



	/* Currenlty supported only for MPLS over UDP */

	if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_MPLS) &&

	    !netif_is_bareudp(filter_dev)) {

		NL_SET_ERR_MSG_MOD(extack,

				   "Matching on MPLS is supported only for MPLS over UDP");

		netdev_err(priv->netdev,

			   "Matching on MPLS is supported only for MPLS over UDP\n");

		return -EOPNOTSUPP;

	}



	return 0;

}