Commit 7d649cfe authored Mar 05, 2021 by Abhinav Kumar Committed by Rob Clark Apr 07, 2021

drm/msm/dp: Fix incorrect NULL check kbot warnings in DP driver



Fix an incorrect NULL check reported by kbot in the MSM DP driver

smatch warnings:
drivers/gpu/drm/msm/dp/dp_hpd.c:37 dp_hpd_connect()
error: we previously assumed 'hpd_priv->dp_cb' could be null
(see line 37)

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/1614971839-2686-2-git-send-email-abhinavk@codeaurora.org


Signed-off-by: Rob Clark <robdclark@chromium.org>

parent 86bf2545

drivers/gpu/drm/msm/dp/dp_hpd.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -34,8 +34,8 @@ int dp_hpd_connect(struct dp_usbpd *dp_usbpd, bool hpd)

		dp_usbpd->hpd_high = hpd;

		if (!hpd_priv->dp_cb && !hpd_priv->dp_cb->configure
		&& !hpd_priv->dp_cb->disconnect) {
		if (!hpd_priv->dp_cb \|\| !hpd_priv->dp_cb->configure
		\|\| !hpd_priv->dp_cb->disconnect) {
		pr_err("hpd dp_cb not initialized\n");
		return -EINVAL;
		}