Commit 7cf58b79 authored by Sven Van Asbroeck's avatar Sven Van Asbroeck Committed by Bjorn Helgaas
Browse files

PCI/PME: Fix possible use-after-free on remove 



In remove(), ensure that the PME work cannot run after kfree() is called.
Otherwise, this could result in a use-after-free.

This issue was detected with the help of Coccinelle.

Signed-off-by: default avatarSven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Cc: Sinan Kaya <okaya@kernel.org>
Cc: Frederick Lawler <fred@fredlawl.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Keith Busch <keith.busch@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 95c80bc6

drivers/pci/pcie/pme.c

+1 −0
Original line number Diff line number Diff line
@@ -437,6 +437,7 @@ static void pcie_pme_remove(struct pcie_device *srv) 


	pcie_pme_disable_interrupt(srv->port, data);

	free_irq(srv->irq, srv);

	cancel_work_sync(&data->work);

	kfree(data);

}