Commit 7ccf089b authored by Liam R. Howlett's avatar Liam R. Howlett Committed by Andrew Morton
Browse files

xen: use vma_lookup() in privcmd_ioctl_mmap() 

vma_lookup() walks the VMA tree for a specific value, find_vma() will
search the tree after walking to a specific value.  It is more efficient
to only walk to the requested value since privcmd_ioctl_mmap() will exit
the loop if vm_start != msg->va.

Link: https://lkml.kernel.org/r/20220906194824.2110408-20-Liam.Howlett@oracle.com


Signed-off-by: default avatarLiam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: default avatarVlastimil Babka <vbabka@suse.cz>
Tested-by: default avatarYu Zhao <yuzhao@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: David Howells <dhowells@redhat.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: SeongJae Park <sj@kernel.org>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 3b0e81a1

drivers/xen/privcmd.c

+1 −1
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ static long privcmd_ioctl_mmap(struct file *file, void __user *udata) 
						     struct page, lru);

		struct privcmd_mmap_entry *msg = page_address(page);



		vma = find_vma(mm, msg->va);

		vma = vma_lookup(mm, msg->va);

		rc = -EINVAL;



		if (!vma || (msg->va != vma->vm_start) || vma->vm_private_data)