Commit 7ccb9667 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Bjorn Helgaas
Browse files

PCI: aardvark: Switch to using devm_gpiod_get_optional() 

Switch the driver to the generic version of gpiod API (and away from
OF-specific variant), so that we can stop exporting
devm_gpiod_get_from_of_node().

Link: https://lore.kernel.org/r/Y3KMEZFv6dpxA+Gv@google.com


Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarPali Rohár <pali@kernel.org>
parent 9abf2313

drivers/pci/controller/pci-aardvark.c

+10 −12
Original line number Diff line number Diff line
@@ -1859,20 +1859,18 @@ static int advk_pcie_probe(struct platform_device *pdev) 
		return ret;

	}



	pcie->reset_gpio = devm_gpiod_get_from_of_node(dev, dev->of_node,

						       "reset-gpios", 0,

						       GPIOD_OUT_LOW,

						       "pcie1-reset");

	pcie->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);

	ret = PTR_ERR_OR_ZERO(pcie->reset_gpio);

	if (ret) {

		if (ret == -ENOENT) {

			pcie->reset_gpio = NULL;

		} else {

		if (ret != -EPROBE_DEFER)

				dev_err(dev, "Failed to get reset-gpio: %i\n",

					ret);

			dev_err(dev, "Failed to get reset-gpio: %i\n", ret);

		return ret;

	}



	ret = gpiod_set_consumer_name(pcie->reset_gpio, "pcie1-reset");

	if (ret) {

		dev_err(dev, "Failed to set reset gpio name: %d\n", ret);

		return ret;

	}



	ret = of_pci_get_max_link_speed(dev->of_node);