Commit 7cca85df authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: elx: libefc: Fix IRQ restore in efc_domain_dispatch_frame() 

Calling a nested spin_lock_irqsave() will overwrite the original "flags" so
that they can not be enabled again at the end.

Link: https://lore.kernel.org/r/YMyjH16k4M1yEmmU@mwanda


Fixes: 3146240f ("scsi: elx: libefc: FC Domain state machine interfaces")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 99cf9226

drivers/scsi/elx/libefc/efc_domain.c

+2 −2
Original line number Diff line number Diff line
@@ -1001,10 +1001,10 @@ efc_domain_dispatch_frame(void *arg, struct efc_hw_sequence *seq) 


	if (node->hold_frames || !list_empty(&node->pend_frames)) {

		/* add frame to node's pending list */

		spin_lock_irqsave(&node->pend_frames_lock, flags);

		spin_lock(&node->pend_frames_lock);

		INIT_LIST_HEAD(&seq->list_entry);

		list_add_tail(&seq->list_entry, &node->pend_frames);

		spin_unlock_irqrestore(&node->pend_frames_lock, flags);

		spin_unlock(&node->pend_frames_lock);

		rc = EFC_HW_SEQ_HOLD;

		goto out_release;

	}