Commit 7c99616e authored by Zack Rusin's avatar Zack Rusin
Browse files

drm: Remove drm_mode_config::fb_base 



The fb_base in struct drm_mode_config has been unused for a long time.
Some drivers set it and some don't leading to a very confusing state
where the variable can't be relied upon, because there's no indication
as to which driver sets it and which doesn't.

The only usage of fb_base is internal to two drivers so instead of trying
to force it into all the drivers to get it into a coherent state
completely remove it.

Signed-off-by: default avatarZack Rusin <zackr@vmware.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarThomas Zimmermann <tzimemrmann@suse.de>
Acked-by: default avatarChristian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221019024401.394617-1-zack@kde.org
parent b389286d

drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c

+0 −2
Original line number Diff line number Diff line
@@ -498,8 +498,6 @@ static int amdgpu_vkms_sw_init(void *handle) 
	adev_to_drm(adev)->mode_config.preferred_depth = 24;

	adev_to_drm(adev)->mode_config.prefer_shadow = 1;



	adev_to_drm(adev)->mode_config.fb_base = adev->gmc.aper_base;



	r = amdgpu_display_modeset_create_props(adev);

	if (r)

		return r;

drivers/gpu/drm/amd/amdgpu/dce_v10_0.c

+0 −2
Original line number Diff line number Diff line
@@ -2800,8 +2800,6 @@ static int dce_v10_0_sw_init(void *handle) 


	adev_to_drm(adev)->mode_config.fb_modifiers_not_supported = true;



	adev_to_drm(adev)->mode_config.fb_base = adev->gmc.aper_base;



	r = amdgpu_display_modeset_create_props(adev);

	if (r)

		return r;

drivers/gpu/drm/amd/amdgpu/dce_v11_0.c

+0 −2
Original line number Diff line number Diff line
@@ -2918,8 +2918,6 @@ static int dce_v11_0_sw_init(void *handle) 


	adev_to_drm(adev)->mode_config.fb_modifiers_not_supported = true;



	adev_to_drm(adev)->mode_config.fb_base = adev->gmc.aper_base;



	r = amdgpu_display_modeset_create_props(adev);

	if (r)

		return r;

drivers/gpu/drm/amd/amdgpu/dce_v6_0.c

+0 −1
Original line number Diff line number Diff line
@@ -2675,7 +2675,6 @@ static int dce_v6_0_sw_init(void *handle) 
	adev_to_drm(adev)->mode_config.preferred_depth = 24;

	adev_to_drm(adev)->mode_config.prefer_shadow = 1;

	adev_to_drm(adev)->mode_config.fb_modifiers_not_supported = true;

	adev_to_drm(adev)->mode_config.fb_base = adev->gmc.aper_base;



	r = amdgpu_display_modeset_create_props(adev);

	if (r)

drivers/gpu/drm/amd/amdgpu/dce_v8_0.c

+0 −2
Original line number Diff line number Diff line
@@ -2701,8 +2701,6 @@ static int dce_v8_0_sw_init(void *handle) 


	adev_to_drm(adev)->mode_config.fb_modifiers_not_supported = true;



	adev_to_drm(adev)->mode_config.fb_base = adev->gmc.aper_base;



	r = amdgpu_display_modeset_create_props(adev);

	if (r)

		return r;