Commit 7c8881b7 authored by Jianglei Nie's avatar Jianglei Nie Committed by Tony Nguyen
Browse files

ice: Fix memory leak in ice_get_orom_civd_data() 



A memory chunk was allocated for orom_data in ice_get_orom_civd_data()
by vzmalloc(). But when ice_read_flash_module() fails, the allocated
memory is not freed, which will lead to a memory leak.

We can fix it by freeing the orom_data when ce_read_flash_module() fails.

Fixes: af18d886 ("ice: reduce time to read Option ROM CIVD data")
Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent d2016651

drivers/net/ethernet/intel/ice/ice_nvm.c

+1 −0
Original line number Diff line number Diff line
@@ -641,6 +641,7 @@ ice_get_orom_civd_data(struct ice_hw *hw, enum ice_bank_select bank, 
	status = ice_read_flash_module(hw, bank, ICE_SR_1ST_OROM_BANK_PTR, 0,

				       orom_data, hw->flash.banks.orom_size);

	if (status) {

		vfree(orom_data);

		ice_debug(hw, ICE_DBG_NVM, "Unable to read Option ROM data\n");

		return status;

	}