Commit 7c81582c authored by Amelie Delaunay's avatar Amelie Delaunay Committed by Lee Jones
Browse files

mfd: stmfx: Nullify stmfx->vdd in case of error 



Nullify stmfx->vdd in case devm_regulator_get_optional() returns an error.
And simplify code by returning an error only if return code is not -ENODEV,
which means there is no vdd regulator and it is not an issue.

Fixes: d75846ed ("mfd: stmfx: Fix dev_err_probe() call in stmfx_chip_init()")
Signed-off-by: default avatarAmelie Delaunay <amelie.delaunay@foss.st.com>
Link: https://lore.kernel.org/r/20230609092804.793100-2-amelie.delaunay@foss.st.com


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent f592cf62

drivers/mfd/stmfx.c

+2 −3
Original line number Diff line number Diff line
@@ -330,9 +330,8 @@ static int stmfx_chip_init(struct i2c_client *client) 
	stmfx->vdd = devm_regulator_get_optional(&client->dev, "vdd");

	ret = PTR_ERR_OR_ZERO(stmfx->vdd);

	if (ret) {

		if (ret == -ENODEV)

		stmfx->vdd = NULL;

		else

		if (ret != -ENODEV)

			return dev_err_probe(&client->dev, ret, "Failed to get VDD regulator\n");

	}