Commit 7c8099f6 authored by Chuck Lever's avatar Chuck Lever Committed by Anna Schumaker
Browse files

SUNRPC: Trace call_refresh events 



Clean up: Replace dprintk call sites.

Note that rpc_call_rpcerror() already has a trace point, so perhaps
adding trace_rpc_refresh_status() isn't necessary. However, it does
report a particular category of error.

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
parent 914cdcc7

include/trace/events/sunrpc.h

+2 −0
Original line number Diff line number Diff line
@@ -262,6 +262,8 @@ DEFINE_RPC_STATUS_EVENT(call); 
DEFINE_RPC_STATUS_EVENT(bind);

DEFINE_RPC_STATUS_EVENT(connect);

DEFINE_RPC_STATUS_EVENT(timeout);

DEFINE_RPC_STATUS_EVENT(retry_refresh);

DEFINE_RPC_STATUS_EVENT(refresh);



TRACE_EVENT(rpc_request,

	TP_PROTO(const struct rpc_task *task),

net/sunrpc/clnt.c

+3 −6
Original line number Diff line number Diff line
@@ -1752,12 +1752,10 @@ call_refreshresult(struct rpc_task *task) 
		if (!task->tk_cred_retry)

			break;

		task->tk_cred_retry--;

		dprintk("RPC: %5u %s: retry refresh creds\n",

				task->tk_pid, __func__);

		trace_rpc_retry_refresh_status(task);

		return;

	}

	dprintk("RPC: %5u %s: refresh creds failed with error %d\n",

				task->tk_pid, __func__, status);

	trace_rpc_refresh_status(task);

	rpc_call_rpcerror(task, status);

}
@@ -1881,8 +1879,7 @@ call_encode(struct rpc_task *task) 
			} else {

				task->tk_action = call_refresh;

				task->tk_cred_retry--;

				dprintk("RPC: %5u %s: retry refresh creds\n",

					task->tk_pid, __func__);

				trace_rpc_retry_refresh_status(task);

			}

			break;

		default: