Commit 7c439ad1 authored by Joe Hattori's avatar Joe Hattori Committed by Wupeng Ma
Browse files

iio: adc: at91: call input_free_device() on allocated iio_dev 

stable inclusion
from stable-v6.6.72
commit 09e067e3c83e0695d338e8a26916e3c2bc44be02
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBIQWA
CVE: CVE-2024-57904

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=09e067e3c83e0695d338e8a26916e3c2bc44be02



--------------------------------

commit de6a73bad1743e9e81ea5a24c178c67429ff510b upstream.

Current implementation of at91_ts_register() calls input_free_deivce()
on st->ts_input, however, the err label can be reached before the
allocated iio_dev is stored to st->ts_input. Thus call
input_free_device() on input instead of st->ts_input.

Fixes: 84882b06 ("iio: adc: at91_adc: Add support for touchscreens without TSMR")
Signed-off-by: default avatarJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://patch.msgid.link/20241207043045.1255409-1-joe@pf.is.s.u-tokyo.ac.jp


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMa Wupeng <mawupeng1@huawei.com>
parent 01e57e5f

drivers/iio/adc/at91_adc.c

+1 −1
Original line number Diff line number Diff line
@@ -984,7 +984,7 @@ static int at91_ts_register(struct iio_dev *idev, 
	return ret;



err:

	input_free_device(st->ts_input);

	input_free_device(input);

	return ret;

}