Commit 7c3e8d9d authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman
Browse files

serial: 8250_exar: Avoid NULL pointer dereference at ->exit() 



It's possible that during ->exit() the private_data is NULL,
for instance when there was no GPIO device instantiated.
Due to this we may not dereference it. Add a respective check.

Note, for now ->exit() only makes sense when GPIO device
was instantiated, that's why we may use the check for entire
function.

Fixes: 81171e7d ("serial: 8250_exar: Constify the software nodes")
Reported-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
Link: https://lore.kernel.org/r/20210608144239.12697-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8124c8a6

drivers/tty/serial/8250/8250_exar.c

+5 −1
Original line number Diff line number Diff line
@@ -553,7 +553,11 @@ static void pci_xr17v35x_exit(struct pci_dev *pcidev) 
{

	struct exar8250 *priv = pci_get_drvdata(pcidev);

	struct uart_8250_port *port = serial8250_get_port(priv->line[0]);

	struct platform_device *pdev = port->port.private_data;

	struct platform_device *pdev;



	pdev = port->port.private_data;

	if (!pdev)

		return;



	device_remove_software_node(&pdev->dev);

	platform_device_unregister(pdev);