Commit 7c3a0a01 authored by Eli Cohen's avatar Eli Cohen Committed by David S. Miller
Browse files

net/{mlx5|nfp|bnxt}: Remove unnecessary RTNL lock assert 



Remove the assert from the callback priv lookup function since it does
not require RTNL lock and is already protected by flow_indr_block_lock.

This will avoid warnings from being emitted to dmesg if the driver
registers its callback after an ingress qdisc was created for a
netdevice.

The warnings started after the following patch was merged:
commit 74fc4f82 ("net: Fix offloading indirect devices dependency on qdisc order creation")

Signed-off-by: default avatarEli Cohen <elic@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 84fb7dfc

drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

+0 −3
Original line number Diff line number Diff line
@@ -1884,9 +1884,6 @@ bnxt_tc_indr_block_cb_lookup(struct bnxt *bp, struct net_device *netdev) 
{

	struct bnxt_flower_indr_block_cb_priv *cb_priv;



	/* All callback list access should be protected by RTNL. */

	ASSERT_RTNL();



	list_for_each_entry(cb_priv, &bp->tc_indr_block_list, list)

		if (cb_priv->tunnel_netdev == netdev)

			return cb_priv;

drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c

+0 −3
Original line number Diff line number Diff line
@@ -300,9 +300,6 @@ mlx5e_rep_indr_block_priv_lookup(struct mlx5e_rep_priv *rpriv, 
{

	struct mlx5e_rep_indr_block_priv *cb_priv;



	/* All callback list access should be protected by RTNL. */

	ASSERT_RTNL();



	list_for_each_entry(cb_priv,

			    &rpriv->uplink_priv.tc_indr_block_priv_list,

			    list)

drivers/net/ethernet/netronome/nfp/flower/offload.c

+0 −3
Original line number Diff line number Diff line
@@ -1767,9 +1767,6 @@ nfp_flower_indr_block_cb_priv_lookup(struct nfp_app *app, 
	struct nfp_flower_indr_block_cb_priv *cb_priv;

	struct nfp_flower_priv *priv = app->priv;



	/* All callback list access should be protected by RTNL. */

	ASSERT_RTNL();



	list_for_each_entry(cb_priv, &priv->indr_block_cb_priv, list)

		if (cb_priv->netdev == netdev)

			return cb_priv;